<html>
<head><meta charset="utf-8"><title>fixing rust-log-analyzer · t-infra · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/index.html">t-infra</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html">fixing rust-log-analyzer</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="219966972"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/219966972" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#219966972">(Dec 15 2020 at 11:42)</a>:</h4>
<p>yesterday I started investigating why rust-log-analyzer wasn't sending any message, after not seeing any in my PR</p>



<a name="219967018"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/219967018" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#219967018">(Dec 15 2020 at 11:43)</a>:</h4>
<p>and it turns out the logic to prevent multiple messages from the same PR was not working properly</p>



<a name="219967034"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/219967034" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#219967034">(Dec 15 2020 at 11:43)</a>:</h4>
<p>I opened <a href="https://github.com/rust-lang/rust-log-analyzer/pull/52">https://github.com/rust-lang/rust-log-analyzer/pull/52</a> and merged it today, but I had to rollback since RLA is affected by the 1.48 UB fix</p>



<a name="219967128"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/219967128" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#219967128">(Dec 15 2020 at 11:44)</a>:</h4>
<div class="codehilite"><pre><span></span><code>thread &#39;tokio-runtime-worker-0&#39; panicked at &#39;attempted to leave type `std::mem::ManuallyDrop&lt;internal::SealedBag&gt;` uninitialized, which is invalid&#39;, /rustc/7eac88abb2e57e752f3302f02be5f3ce3d7adfb4/library/core/src/mem/mod.rs:658:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Segmentation fault (core dumped)
</code></pre></div>



<a name="219967662"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/219967662" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#219967662">(Dec 15 2020 at 11:51)</a>:</h4>
<p>pushed a <code>cargo update</code></p>



<a name="219969209"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/219969209" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#219969209">(Dec 15 2020 at 12:08)</a>:</h4>
<p>ok it seems like RLA is now actually learning from positive builds!</p>



<a name="219978239"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/219978239" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#219978239">(Dec 15 2020 at 13:29)</a>:</h4>
<p>opened <a href="https://github.com/rust-lang/rust-log-analyzer/pull/53">https://github.com/rust-lang/rust-log-analyzer/pull/53</a> to avoid learning the same job multiple times</p>



<a name="219995996"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/219995996" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#219995996">(Dec 15 2020 at 15:39)</a>:</h4>
<p>ok learning is finally working <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span></p>



<a name="219996136"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/219996136" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#219996136">(Dec 15 2020 at 15:40)</a>:</h4>
<p><a href="/user_uploads/4715/SrpM9iPF8HO0tc5wH8uLmVI8/2020-12-15-16-40-21.png">2020-12-15-16-40-21.png</a></p>
<div class="message_inline_image"><a href="/user_uploads/4715/SrpM9iPF8HO0tc5wH8uLmVI8/2020-12-15-16-40-21.png" title="2020-12-15-16-40-21.png"><img src="/user_uploads/4715/SrpM9iPF8HO0tc5wH8uLmVI8/2020-12-15-16-40-21.png"></a></div>



<a name="220025442"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/220025442" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#220025442">(Dec 15 2020 at 18:59)</a>:</h4>
<p>and the error messages are alive <span aria-label="tada" class="emoji emoji-1f389" role="img" title="tada">:tada:</span> <br>
<a href="https://github.com/rust-lang/rust/pull/79979#issuecomment-745388679">https://github.com/rust-lang/rust/pull/79979#issuecomment-745388679</a></p>



<a name="220117265"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/220117265" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#220117265">(Dec 16 2020 at 13:53)</a>:</h4>
<p>also for auto builds!</p>



<a name="220117268"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/220117268" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#220117268">(Dec 16 2020 at 13:53)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/pull/80064#issuecomment-745593170">https://github.com/rust-lang/rust/pull/80064#issuecomment-745593170</a></p>



<a name="220117287"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/220117287" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#220117287">(Dec 16 2020 at 13:53)</a>:</h4>
<p>and wow that snippet was perfect</p>



<a name="220568883"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/220568883" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> RalfJ <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#220568883">(Dec 21 2020 at 10:06)</a>:</h4>
<p><span class="user-mention silent" data-user-id="121055">Pietro Albini</span> <a href="#narrow/stream/242791-t-infra/topic/fixing.20rust-log-analyzer/near/219967034">said</a>:</p>
<blockquote>
<p>I opened <a href="https://github.com/rust-lang/rust-log-analyzer/pull/52">https://github.com/rust-lang/rust-log-analyzer/pull/52</a> and merged it today, but I had to rollback since RLA is affected by the 1.48 UB fix</p>
</blockquote>
<p>if that's still a problem, let me know if I can help resolve this issue (I couldnt see a fix being pushed but maybe I am looking in the wrong place).</p>



<a name="220568952"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/242791-t-infra/topic/fixing%20rust-log-analyzer/near/220568952" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/242791-t-infra/topic/fixing.20rust-log-analyzer.html#220568952">(Dec 21 2020 at 10:06)</a>:</h4>
<p><span class="user-mention" data-user-id="120791">@RalfJ</span> nah it's fixed, a <code>cargo update</code> to bring tokio/hyper up to date fixed it</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>